sync::watch::Receiver: Fix changed handling on version overflow
#6017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
changed the title
uklotzde
force-pushed
the
sync-watch-fix-changed-handling-on-overflow
branch
from
10bd2f4
to
5efb901
Compare
|
I have also added and renamed some constants. They depend on each other and their definition and documentation should be colocated. |
Darksonn
changed the title
sync::watch::Receiver: Fix changed handling on version overflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
sync::watch::Receiver: The asymmetric implementation ofVersion::decrement()fails after an overflow of the version number. This is an edge case that might occur in long running applications.Solution
Consistently use wrapping add/sub semantics for both
AtomicUsizeandusizeoperations when incrementing/decrementing version numbers. This also allows to start the version numbering at 0 as before.